[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 1/2] target/arm: Send interrupts on PMU coun
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v11 1/2] target/arm: Send interrupts on PMU counter overflow |
|
Date: |
Wed, 23 Jan 2019 15:37:16 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/23/19 1:32 PM, Aaron Lindsay OS wrote:
> + uint64_t overflow_mask = env->cp15.c9_pmcr & PMCRLC ? \
> + INT64_MIN : INT32_MIN;
With type promotion, this is the same as writing
? 0x8000000000000000ull : 0xffffffff80000000ull
which is probably not what you were intending.
Perhaps just ? 1ull << 63 : 1ull << 31 is better?
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~