[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 47/50] paaudio: channel-map option
From: |
Zoltán Kővágó |
Subject: |
Re: [Qemu-devel] [PATCH v3 47/50] paaudio: channel-map option |
Date: |
Wed, 23 Jan 2019 21:13:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-17 11:03, Gerd Hoffmann wrote:
> On Thu, Jan 17, 2019 at 12:37:20AM +0100, Kővágó, Zoltán wrote:
>> Add an option to change the channel map used by pulseaudio. If not
>> specified, falls back to an OSS compatible channel map.
>>
>> Signed-off-by: Kővágó, Zoltán <address@hidden>
>> ---
>> qapi/audio.json | 5 ++++-
>> audio/paaudio.c | 18 ++++++++++++++----
>> qemu-options.hx | 9 +++++++++
>> 3 files changed, 27 insertions(+), 5 deletions(-)
>>
>> diff --git a/qapi/audio.json b/qapi/audio.json
>> index 7bcea6240f..86078039dc 100644
>> --- a/qapi/audio.json
>> +++ b/qapi/audio.json
>> @@ -107,11 +107,14 @@
>> #
>> # @name: name of the sink/source to use
>> #
>> +# @channel-map: channel map to use (default: OSS compatible map)
>> +#
>> # Since: 4.0
>> ##
>> { 'struct': 'AudiodevPaPerDirectionOptions',
>> 'data': {
>> - '*name': 'str' } }
>> + '*name': 'str',
>> + '*channel-map': 'str' } }
>
> Ah, I see. Thats why patch #1 creates a AudiodevPaPerDirectionOptions
> struct with just one field ...
Yes, I was bitten by it too during a refactor, probably I should write a
few words about it in the commit message.
However, this is the exact reason I'd recommend nested structs instead
of randomly flattening it when we can. This way, if we later have to
add an extra option, we don't end up in a problematic situation, since
we can't easily change things like 'dev-in' to a structure without
breaking backward compatibility.
Regards,
Zoltan
- [Qemu-devel] [PATCH v3 26/50] audio: api for mixeng code free backends, (continued)
- [Qemu-devel] [PATCH v3 26/50] audio: api for mixeng code free backends, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 48/50] usb-audio: do not count on avail bytes actually available, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 41/50] audio: add mixeng option (documentation), Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 27/50] alsaaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 40/50] audio: split ctl_* functions into enable_* and volume_*, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 34/50] spiceaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 42/50] audio: make mixeng optional, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 47/50] paaudio: channel-map option, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 29/50] dsoundaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 31/50] ossaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 25/50] audio: use size_t where makes sense, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 50/50] usbaudio: change playback counters to 64 bit, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 38/50] audio: remove hw->samples, buffer_size_in/out pcm_ops, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 39/50] audio: common rate control code for timer based outputs, Kővágó, Zoltán, 2019/01/16