Re: [Qemu-devel] [PATCH] input-linux: customizable grab toggle keys v5

[Gerd Hoffmann]

On Tue, Jan 22, 2019 at 03:56:27PM -0500, Ryan El Kochta wrote:
> Here is an updated version of my previous patch. Ctrl-Alt has been
> removed, as per your recommendation, and Ctrl-Scrolllock has been
> changed so as to trigger when either ctrl key is pressed, for a
> consistent naming scheme. I do agree that this is the best way forward.
> 
> Ctrl-Backtick is also gone.
> 
> I've tested these on a Windows and Linux guest and they all appear to
> work fine.

Almost there.  Code is fine now, but the commit message describes the v4
-> v5 changes instead of describing the patch.  The v4 message was much
better.

Can you grab the v4 commit message and adapt the text to the v5 code
changes?

A better place to list the changes is the patch series cover letter
(yes, you can send a cover letter with a single patch too).

Some people use "git notes" + "git format-patch --notes" for changelog
annotations.  That'll work too.

> Quick aside; I'm sorry if this e-mail isn't a reply to the old thread. I
> haven't quite figured that one out yet :-)

Starting a new thread is perfectly fine and in fact the preferred way to
send a new patch revision.

cheers,
  Gerd