qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v2 06/37] hw/mips/Makefile.objs: Create CONF


From: Yang Zhong
Subject: Re: [Qemu-devel] [RFC PATCH v2 06/37] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
Date: Thu, 17 Jan 2019 19:44:20 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jan 16, 2019 at 09:34:15AM +0100, Thomas Huth wrote:
> On 2019-01-15 15:10, Yang Zhong wrote:
[...] 
> I think that change to the CONFIG_VT82C686 is unrelated and should not
> be part of this patch. Also looking at commit
> 
>  dff4021730b112ca00522d4c98c24a15feeef5a0
>  mips: Remove CONFIG_VT82C686 from non-Fulong configs
> 
> it seems like it should stay in mips64el-softmmu.mak and not be moved to
> mips-softmmu-common.mak.
> 
  Hello Thomas,

  Wow, you can find this corner case, and thanks for you detailed review.

  Regards,

  Yang

>  Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]