[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID any
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore |
Date: |
Thu, 10 Jan 2019 12:22:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/10/19 11:06 AM, Dr. David Alan Gilbert wrote:
>>> savevm [-t] [-i] [tag|id]
>>>
>>> then:
>>> a) with neither -t or -i it would behave in the same roulette way
>>> as it does in the moment, and it might be a tag or id
>>>
>>> b) with -t we'd explicitly treat the parameter as a tag and it
>>> would error if it wasn't found
>>>
>>> c) With -i we'd explicitly treat the parameter as an id and
>>> it would error if it wasn't found
>>>
>>> Since we still allow (a) it doesn't break any existing code.
>>
>> If you can explain why we need both tag and id?
>>
>> And by keeping the current behaviour, we might not break hypothetically
>> existing correct code, but we leave currently actually existing broken
>> code like libvirt broken.
>
> My only reason for leaving both tag & id was for the hypothetical
> existing current code; my assumption adding the above would be that we
> would then fix libvirt never to use (a), probably always (b).
How? HMP is not introspectible, so libvirt can't know if 'savevm -t'
works without trying it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, (continued)
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Max Reitz, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Eric Blake, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Eric Blake, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Dr. David Alan Gilbert, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Daniel Henrique Barboza, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Dr. David Alan Gilbert, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Max Reitz, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Max Reitz, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Daniel Henrique Barboza, 2019/01/09
Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Eric Blake, 2019/01/09