[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 12/19] travis: stop redefining the script command
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH v1 12/19] travis: stop redefining the script commands |
Date: |
Thu, 10 Jan 2019 17:45:09 +0000 |
From: Daniel P. Berrangé <address@hidden>
One of the matrix entries redefines the script command in order to add
the ${MAKEFLAGS} variable. Ideally ${MAKEFLAGS} would be referenced by
the definition of the ${TEST_CMD} env variable, but this isn't possible
in travis. ${MAKEFLAGS} exists to eliminate duplication of flags in
every "make" command, but this cure causes a worse problem, namely the
reduplication of the "script" command. It is simpler to just insert "-j3"
directly into any "make" command.
Signed-off-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
---
.travis.yml | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 2ef7997d25..7b18d33e9d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -65,8 +65,7 @@ env:
global:
- SRC_DIR="."
- BUILD_DIR="."
- - TEST_CMD="make check"
- - MAKEFLAGS="-j3"
+ - TEST_CMD="make check -j3"
git:
@@ -78,7 +77,7 @@ before_script:
- mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
- ${SRC_DIR}/configure ${CONFIG} || { cat config.log && exit 1; }
script:
- - make ${MAKEFLAGS} && ${TEST_CMD}
+ - make -j3 && ${TEST_CMD}
matrix:
@@ -255,9 +254,7 @@ matrix:
- env:
- CONFIG="--disable-system --disable-docs"
- - TEST_CMD="make check-tcg"
- script:
- - make ${MAKEFLAGS} && ${TEST_CMD} ${MAKEFLAGS}
+ - TEST_CMD="make -j3 check-tcg"
sudo: required
dist: trusty
compiler: gcc
--
2.17.1
- [Qemu-devel] [PATCH v1 00/19] testing/next queue for travis and docker, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 06/19] tests: use in-place sed magic for enabling deb-src in travis image, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 08/19] travis: define all the build matrix entries in one place, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 12/19] travis: stop redefining the script commands,
Alex Bennée <=
- [Qemu-devel] [PATCH v1 14/19] travis: run tests in verbose mode, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 04/19] tests: update Fedora dockerfile to use Fedora 29, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 10/19] travis: don't clone git submodules upfront, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 18/19] tests/docker: update our Travis image, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 11/19] travis: use homebrew addon for MacOSX, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 05/19] tests: update Fedora i386 cross image to Fedora 29, Alex Bennée, 2019/01/10
- [Qemu-devel] [PATCH v1 03/19] tests: remove obsolete 'debian' dockerfile, Alex Bennée, 2019/01/10