Re: [Qemu-devel] [PATCH v6 11/11] iotests: add iotest 236 for testing bitmap merge

[Eric Blake]

On 12/21/18 3:35 AM, John Snow wrote:
> New interface, new smoke test.
> 
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  tests/qemu-iotests/236     | 161 +++++++++++++++++
>  tests/qemu-iotests/236.out | 351 +++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 513 insertions(+)
>  create mode 100755 tests/qemu-iotests/236
>  create mode 100644 tests/qemu-iotests/236.out
> 
> diff --git a/tests/qemu-iotests/236 b/tests/qemu-iotests/236
> new file mode 100755
> index 0000000000..79a6381f8e
> --- /dev/null
> +++ b/tests/qemu-iotests/236

> +    log('\n--- Submitting & Aborting Merge Transaction ---\n')

You updated the test but forgot to update 236.out:

236         - output mismatch (see 236.out.bad)
--- /home/eblake/qemu/tests/qemu-iotests/236.out        2019-01-08
17:16:10.938311529 -0600
+++ /home/eblake/qemu/tests/qemu-iotests/236.out.bad    2019-01-08
20:46:21.240645478 -0600
@@ -37,7 +37,7 @@
   }
 }

---- Submitting Bad Transaction ---
+--- Submitting & Aborting Transaction ---

 {
   "execute": "transaction",
@@ -201,7 +201,7 @@
   }
 }

---- Submitting Bad Merge ---
+--- Submitting & Aborting Merge Transaction ---

 {
   "execute": "transaction",


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature