[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 23/27] target/arm: Implement pauth_computepac
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 23/27] target/arm: Implement pauth_computepac |
|
Date: |
Tue, 8 Jan 2019 15:00:19 +1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/8/19 12:09 AM, Peter Maydell wrote:
>> +static int rot_cell(int cell, int n)
>> +{
>> + cell |= cell << 4;
>> + cell >>= n;
>> + return cell & 0xf;
>
> This doesn't seem to do what the RotCell pseudocode does?
> Unless I've made an error, RotCell(ABCD, 1) == BCDA,
> but rot_cell(ABCD, 1) == DABC.
Yep, I mis-read the direction of the rotate.
Thanks for all of the proof-reading.
This section I found particularly eye watering.
r~