[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] fp-bench: fix update_random_ops
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] fp-bench: fix update_random_ops |
Date: |
Mon, 7 Jan 2019 18:51:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/21/18 8:51 PM, Emilio G. Cota wrote:
> The second test in the branches is wrong; fix while converting
> to a switch statement, which is easier to get right.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> tests/fp/fp-bench.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c
> index f5bc5edebf..546bac9c9c 100644
> --- a/tests/fp/fp-bench.c
> +++ b/tests/fp/fp-bench.c
> @@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision
> prec)
> for (i = 0; i < n_ops; i++) {
> uint64_t r = random_ops[i];
>
> - if (prec == PREC_SINGLE || PREC_FLOAT32) {
:)
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> + switch (prec) {
> + case PREC_SINGLE:
> + case PREC_FLOAT32:
> do {
> r = xorshift64star(r);
> } while (!float32_is_normal(r));
> - } else if (prec == PREC_DOUBLE || PREC_FLOAT64) {
> + break;
> + case PREC_DOUBLE:
> + case PREC_FLOAT64:
> do {
> r = xorshift64star(r);
> } while (!float64_is_normal(r));
> - } else {
> + break;
> + default:
> g_assert_not_reached();
> }
> random_ops[i] = r;
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 1/2] fp-bench: fix update_random_ops,
Philippe Mathieu-Daudé <=