qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX
Date: Mon, 7 Jan 2019 08:26:15 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 1/7/19 3:54 AM, Gerd Hoffmann wrote:
>> The first one is fixable with an explicit cast (ugly but works), but the
>> second one is more problematic. It means we can't write stuff like
>>
>> USBPort  uports[MAX(MAXPORTS_2, MAXPORTS_3)];
>>
>> when not in a function. So we either need a dumb version of MIN/MAX, or
>> scrape the idea altogether.
> 
> const_max() for stuff which is a compile time constant maybe?

The conversation on MIN/MAX has been extracted to a new thread:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00727.html
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00695.html

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]