On Thu, 3 Jan 2019 11:17:00 +0100
Pierre Morel <address@hidden> wrote:
+static void fmb_update(void *opaque)
+{
+ S390PCIBusDevice *pbdev = opaque;
+ int64_t t = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL);
+ int i;
+
+ /* Update U bit */
+ pbdev->fmb.last_update *= 2;
+ pbdev->fmb.last_update |= UPDATE_U_BIT;
+ if (fmb_do_update(pbdev, offsetof(ZpciFmb, last_update),
+ pbdev->fmb.last_update,
+ sizeof(((ZpciFmb *)0)->last_update))) {
I really don't want to be a pain, but... this looks weird. Why not
simply sizeof(pbdev->fmb.last_update)?