Re: [Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties

[Eduardo Habkost]

On Fri, Jan 04, 2019 at 03:42:08PM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Dec 21, 2018 at 1:04 PM Marc-André Lureau
> <address@hidden> wrote:
> >
> > Hi,
> >
> > During "[PATCH v2 05/10] qom/globals: generalize
> > object_property_set_globals()" review, Eduardo suggested to rework the
> > GlobalProperty handling, so that -global is limited to QDev only and
> > we avoid mixing the machine compats and the user-provided -global
> > properties (instead of generalizing -global to various object kinds,
> > like I proposed in v2).
> >
> > "qdev: do not mix compat props with global props" patch decouples a
> > bit user-provided -global from machine compat properties. This allows
> > to get rid of "user_provided" and "errp" fields in following patches.
> >
> > A new compat property "x-use-canonical-path-for-ramblock-id" is added
> > to hostmem for legacy canonical path names, set to true for -file and
> > -memfd with qemu < 4.0.
> >
> > (this series was initially titled "[PATCH v2 00/10] hostmem: use
> > object "id" for memory region name with >= 3.1", but its focus is more
> > in refactoring the global and compatilibity properties handling now)
> >
> 
> Beside the rebase conflicts, and added comment in patch 25, all
> patches have been reviewed-by. I have pushed the rebased version on
> github: https://github.com/elmarco/qemu/tree/props
> 
> Eduardo, Igor, who is making the pullreq? I could also send it, if you are 
> okay.

I was planning to merge this next week, but if you are willing to
send the pull request, that's even better.  Thanks!

Acked-by: Eduardo Habkost <address@hidden>

-- 
Eduardo