Re: [Qemu-devel] [PULL v2 00/44] MIPS pull request for December 2018 - v2

[Thomas Huth]

On 2019-01-03 14:32, Philippe Mathieu-Daudé wrote:
> On 1/3/19 2:23 PM, Peter Maydell wrote:
>> On Mon, 31 Dec 2018 at 14:56, Aleksandar Markovic
>> <address@hidden> wrote:
>>> MIPS queue for December 2018 - v2
> [...]
>> Hi; I'm afraid this doesn't build on all my test hosts:
>>
>> target/mips/translate.c: In function ‘gen_mxu_Q8MAX_Q8MIN’:
>> target/mips/translate.c:25092:9: error: ‘for’ loop initial
>> declarations are only allowed in C99 mode
>>          for (int i = 2; i >= 0; i--) {
>>          ^
>> target/mips/translate.c:25092:9: note: use option -std=c99 or
>> -std=gnu99 to compile your code
>> target/mips/translate.c:25129:9: error: ‘for’ loop initial
>> declarations are only allowed in C99 mode
>>          for (int i = 2; i >= 0; i--) {
>>          ^
>>
>> (This probably only shows up on builds with older versions
>> of gcc which don't default to c99.)
>>
>> We don't use variable-declaration-in-for-loop.
> 
> Hmmm I wonder if we shouldn't relax that now than all supported
> compilers do support C99.

Maybe we could / should enforce compiling with -std=gnu11 now? That
would also fix the problem with the duplicated typedefs on older
compilers, see e.g.:

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html

 Thomas