[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 0/5] Fix strncpy() warnings for GCC8 new -Wstring
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v5 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation |
Date: |
Thu, 3 Jan 2019 09:56:33 +0100 |
GCC 8 new warning prevents builds to success since quite some time.
First report on the mailing list is in July 2018:
https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html
Since v4:
- fixed some checkpatch errors/warnings reported by patchew
- commented checkpatch errors/warnings false positives
- added Reviewed-by
Now this series is fully reviewed.
Since v3:
- patch 1: make sens of description (eblake)
- patch 2: append QEMU_NONSTRING instead of prepending it (mst)
- patch 3: rebased (imammedo), intented
- patch 4: replaced by Marc-André first attempt, improved doc
- patch 5: add assert() and NUL-terminate the buffer (mst)
Various intents has been sent to fix this:
- Incorrectly using g_strlcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html
- Using assert() and strpadcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html
This was the approch taken by the previous v2:
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04405.html
- Use #pragma GCC diagnostic ignored "-Wstringop-truncation"
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- adding an inline wrapper with said pragma in there
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- -Wno-stringop-truncation is the makefile
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- Use the 'nonstring' attribute
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04493.html
This series add the QEMU_NONSTRING definition and use it.
Regards,
Phil.
v4: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg06175.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04596.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04405.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html
Marc-André Lureau (1):
migration: Fix stringop-truncation warning
Philippe Mathieu-Daudé (4):
qemu/compiler: Define QEMU_NONSTRING
block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays
hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays
migration: Use strnlen() for fixed-size string
block/sheepdog.c | 2 +-
hw/acpi/core.c | 12 ++++++++----
include/hw/acpi/acpi-defs.h | 13 ++++++++-----
include/qemu/compiler.h | 15 +++++++++++++++
migration/global_state.c | 15 ++++++++++++++-
5 files changed, 46 insertions(+), 11 deletions(-)
--
2.17.2
- [Qemu-devel] [PATCH v5 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v5 1/5] qemu/compiler: Define QEMU_NONSTRING, Philippe Mathieu-Daudé, 2019/01/03
- [Qemu-devel] [PATCH v5 2/5] block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays, Philippe Mathieu-Daudé, 2019/01/03
- [Qemu-devel] [PATCH v5 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays, Philippe Mathieu-Daudé, 2019/01/03
- [Qemu-devel] [PATCH v5 4/5] migration: Fix stringop-truncation warning, Philippe Mathieu-Daudé, 2019/01/03
- [Qemu-devel] [PATCH v5 5/5] migration: Use strnlen() for fixed-size string, Philippe Mathieu-Daudé, 2019/01/03