Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

[Thomas Huth]

On 2019-01-02 20:34, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
> 
> On 1/2/19 4:46 PM, Thomas Huth wrote:
>> These files / devices are only used by SPARC machines, so we can sort
>> them into the corresponding categories in the MAINTAINERS file.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  MAINTAINERS | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b6c2645..e897963 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <address@hidden>
>>  S: Maintained
>>  F: hw/sparc/sun4m.c
>>  F: hw/sparc/sun4m_iommu.c
>> +F: hw/display/cg3.c
>> +F: hw/display/tcx.c
>>  F: hw/dma/sparc32_dma.c
>>  F: hw/misc/eccmemctl.c
>> -F: hw/misc/slavio_misc.c
>> +F: hw/*/slavio_*.c
>>  F: include/hw/sparc/sparc32_dma.h
>>  F: pc-bios/openbios-sparc32
>>  F: include/hw/sparc/sun4m_iommu.h
>> @@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
>>  F: pc-bios/openbios-sparc64
>>  F: hw/pci-host/sabre.c
>>  F: include/hw/pci-host/sabre.h
>> +F: include/hw/sparc/sun4u_iommu.h
> 
> I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html

Oh, right, sorry!

> Neither mine nor your are complete :)
> Can I include your patch when respining the series? (Not sure I need to
> respin although).

Sure!

>> +F: include/hw/nvram/sun_nvram.h
> 
> sun_nvram.h is also used by sun4m (the previous section this patch updates).

Right. So it should maybe be listed twice... (but since the maintainer
of sun4u and sun4m is the same, it likely does not really matter)

 Thomas