Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Programmingkid]

> On Dec 31, 2018, at 12:00 PM, address@hidden wrote:
> 
> Message: 2
> Date: Mon, 31 Dec 2018 16:50:47 +0100
> From: "=?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?=" <address@hidden>
> To: Programmingkid <address@hidden>
> Cc: QEMU Developers <address@hidden>, Gerd Hoffmann
>       <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset=utf-8
> 
> On 2018-12-29 01:49, Programmingkid wrote:
>> 
>>> On Dec 28, 2018, at 7:19 PM, Zolt?n K?v?g? <address@hidden> wrote:
>>> 
>>> On 2018-12-29 01:12, Programmingkid wrote:
>>>> 
>>>>> On Dec 28, 2018, at 3:05 PM, K?v?g? Zolt?n <address@hidden> wrote:
>>>>> 
>>>>> On 2018-12-28 01:46, Programmingkid wrote:
>>>>>> 
>>>>>>> On Dec 27, 2018, at 8:33 AM, K?v?g? Zolt?n <address@hidden> wrote:
>>>>>>> 
>>>>>>> Hi,
>>>>>>> 
>>>>>>> I've pushed it to my github (modulo some random fixes not yet on the
>>>>>>> mailing list):
>>>>>>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>>>>>> 
>>>>>>> I don't have a mac so I have no idea whether it works or not.
>>>>>>> 
>>>>>>> Regards,
>>>>>>> Zoltan
>>>>>>> 
>>>>>>> On 2018-12-26 12:24, Programmingkid wrote:
>>>>>>>> 
>>>>>>>>> On Dec 23, 2018, at 3:52 PM, address@hidden wrote:
>>>>>>>>> 
>>>>>>>>> Message: 4
>>>>>>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>>>>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>>>>>>>       <address@hidden>
>>>>>>>>> To: address@hidden
>>>>>>>>> Cc: Gerd Hoffmann <address@hidden>
>>>>>>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>>>>>>> Message-ID: <address@hidden>
>>>>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>>>>> 
>>>>>>>>> Hi,
>>>>>>>>> 
>>>>>>>>> I've updated my audio patchset to the current git master. Other than 
>>>>>>>>> that not
>>>>>>>>> much happened since my last update [1], fixed a few small problems 
>>>>>>>>> that I
>>>>>>>>> noticed while rebasing my patches.
>>>>>>>>> 
>>>>>>>>> Please review.
>>>>>>>> 
>>>>>>>> <snip>
>>>>>>>> 
>>>>>>>> Hi I would like to run your patches. Do you have a repository that I 
>>>>>>>> may clone? 
>>>>>>>> 
>>>>>>>> Also have you been able to test these patches using a Mac OS X guest 
>>>>>>>> yet? 
>>>>>>>> 
>>>>>>>> Thank you.
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> Hi, thanks for the link. This is what I did:
>>>>>> 
>>>>>> - git clone https://github.com/DirtYiCE/qemu.git
>>>>>> - git checkout audio-51-2018
>>>>>> - ./configure --target-list=ppc-softmmu
>>>>>> - make -j 4
>>>>>> 
>>>>>> The result was unfortunately some errors:
>>>>>> 
>>>>>> CC      audio/coreaudio.o
>>>>>> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you 
>>>>>> mean
>>>>>>   'HWVoiceOut'?
>>>>>> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t 
>>>>>> *size),
>>>>>>                                             ^~~~~~~~~~
>>>>>>                                             HWVoiceOut
>>>>>> 
>>>>>> 
>>>>>> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to 
>>>>>> parameter of
>>>>>>   incompatible type 'struct audio_pcm_info *'; take the address with &
>>>>>>     coreaudio_get_flags(hw->info, as);
>>>>>>                         ^~~~~~~~
>>>>>>                         &
>>>>>> 
>>>>>> 
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> I pushed an updated version, it should fix the compile errors (hopefully).
>>>>> 
>>>>> Regards,
>>>>> Zoltan
>>>> 
>>>> Thank you for the update. I tested this series using a Mac OS 10.4 and 
>>>> Windows 2000 guest. Both were using a USB sound card. The sound that comes 
>>>> out of my speakers is demonic! It is the loudest, scariest sound I have 
>>>> ever heard. I'm sorry but this patch series ruins the USB sound card.
>>>> 
>>>> I am happy to test out any future updates that you make this patch series. 
>>>> 
>>>> Thank you.
>>>> 
>>> 
>>> I'm sorry to hear that. Could you please test it with some other card,
>>> like the hda? Even though usb works fine for me on Linux with alsa so
>>> the problem is probably with the coreaudio backend.
>>> 
>>> Regards,
>>> Zoltan
>> 
>> I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic 
>> sound.
>> With the above configuration but with an es1370 sound card I heard the same 
>> sound. I kept seeing "es1370: warning: non looping mode" being printed in 
>> the terminal. This problem might need its own patch.
>> Using the sb16 sound card I heard the same unsettling sound.
>> 
>> I could not test the HDA driver due to problems with my Windows 7 VM.  
>> 
> 
> 
> I have a feeling that bf870a0cf5e2c2dd7438e65473b4fca1fb0ca5d1
> (coreaudio: port to the new audio backend api) is the commit which
> breaks it, but without a mac I don't know how could I debug it. The way
> it initializes coreaudio changed a bit, that can cause problems.
> Could you please test whether this commit is the culprit or not?
> 
> Regards,
> Zoltan


Hi how do you want me to test your theory? Revert the patch? If I did I don't 
think QEMU would still compile.