[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 7/7] keymap: fix keyup mappings
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 7/7] keymap: fix keyup mappings |
Date: |
Fri, 21 Dec 2018 11:19:03 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Dec 19, 2018 at 01:09:04PM +0100, Gerd Hoffmann wrote:
> It is possible that the modifier state on keyup is different from the
> modifier state on keydown. In that case the keycode lookup can end up
> with different keys in case multiple keysym -> keycode mappings exist,
> because it picks the mapping depending on modifier state.
>
> To fix that change the lookup logic for keyup events. Instead of
> looking at the modifier state check the key state and prefer a keycodes
> where the key is in "down" state right now.
>
> Fixes: abb4f2c965 keymap: consider modifier state when picking a mapping
> Buglink: https://bugs.launchpad.net/bugs/1738283
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1658676
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> ui/keymaps.h | 2 +-
> ui/curses.c | 2 +-
> ui/keymaps.c | 55 ++++++++++++++++++++++++++++++++++---------------------
> ui/vnc.c | 2 +-
> 4 files changed, 37 insertions(+), 24 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [RFC PATCH v2 3/7] sdl2: use only QKeyCode in sdl2_process_key(), (continued)
- [Qemu-devel] [RFC PATCH v2 2/7] kbd-state: use state tracker for sdl2, Gerd Hoffmann, 2018/12/19
- [Qemu-devel] [RFC PATCH v2 4/7] kbd-state: use state tracker for gtk, Gerd Hoffmann, 2018/12/19
- [Qemu-devel] [RFC PATCH v2 5/7] kbd-state: use state tracker for vnc, Gerd Hoffmann, 2018/12/19
- [Qemu-devel] [RFC PATCH v2 6/7] keymap: pass full keyboard state to keysym2scancode, Gerd Hoffmann, 2018/12/19
- [Qemu-devel] [RFC PATCH v2 7/7] keymap: fix keyup mappings, Gerd Hoffmann, 2018/12/19
- Re: [Qemu-devel] [RFC PATCH v2 7/7] keymap: fix keyup mappings,
Daniel P . Berrangé <=
- Re: [Qemu-devel] [RFC PATCH v2 0/7] ui: add generic keyboard state tracker, fix keymap, no-reply, 2018/12/25