Re: [Qemu-devel] [PATCH v3 2/2] hw: vmmouse: Use link instead of pointer property

[Philippe Mathieu-Daudé]

On 12/17/18 8:01 PM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <address@hidden> writes:
> 
>> Hi Li,
>>
>> On 11/29/18 5:52 AM, Li Qiang wrote:
>>> According to qdev-properties.h, properties of pointer type should
>>> be avoided. Turn "ps2_mouse" into a link.
>>>
>>> Reviewed-by: Markus Armbruster <address@hidden>
>>> Reviewed-by: Darren Kenny <address@hidden>
>>> Signed-off-by: Li Qiang <address@hidden>
>>> ---
> [...]
>>> diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
>>> index 4412eaf604..f63aac6673 100644
>>> --- a/hw/i386/vmmouse.c
>>> +++ b/hw/i386/vmmouse.c
> [...]
>>> @@ -283,8 +289,6 @@ static void vmmouse_class_initfn(ObjectClass *klass, 
>>> void *data)
>>>      dc->realize = vmmouse_realizefn;
>>>      dc->reset = vmmouse_reset;
>>>      dc->vmsd = &vmstate_vmmouse;
>>> -    dc->props = vmmouse_properties;
>>> -    /* Reason: pointer property "ps2_mouse" */
>>>      dc->user_creatable = false;
>>
>> "user_creatable = false" must have an justification comment.
> 
> Correct.
> 
>> Can you keep 'Reason: link property "ps2_mouse"'?
> 
> Is this a valid reason?
> 
> A pointer property is one, because it can only be set by code.

I prefer the original comment :)

/* Reason: pointer property "ps2_mouse" */

>> Eventually the maintainer taking this patch can fix this for you.
>>
>> With the comment:
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>>
>>>  }
> [...]
>