Re: [Qemu-devel] [PATCH v3] s390x/pci: add common function measurement block

[Pierre Morel]

On 14/12/2018 15:20, Cornelia Huck wrote:
> On Fri, 14 Dec 2018 15:11:18 +0100
> Pierre Morel <address@hidden> wrote:
>
> > From: Yi Min Zhao <address@hidden>
> >
> > Common function measurement block is used to report zPCI internal
> > counters of successful pcilg/stg/stb and rpcit instructions to
> > a memory location provided by the program.
> >
> > This patch introduces a new ZpciFmb structure and schedules a timer
> > callback to copy the zPCI measures to the FMB in the guest memory
> > at an interval time set to 4s by default.
> >
> > An error while attemping to update the FMB, would generated an error
> > event to the guest.
> >
> > The pcilg/stg/stb and rpcit interception handlers issue, increase
> > the related counter on success.
> > The guest shall pass a null FMBA (FMB address) in the FIB (Function
> > Information Block) when it issues a Modify PCI Function Control
> > instrcuction to switch off FMB and stop the corresponding timer.
> >
> > Signed-off-by: Yi Min Zhao <address@hidden>
> > Signed-off-by: Pierre Morel <address@hidden>
> > ---
> >   hw/s390x/s390-pci-bus.c  |   4 +-
> >   hw/s390x/s390-pci-bus.h  |  29 ++++++++++
> >   hw/s390x/s390-pci-inst.c | 138 +++++++++++++++++++++++++++++++++++++++++++++--
> >   hw/s390x/s390-pci-inst.h |   1 +
> >   4 files changed, 168 insertions(+), 4 deletions(-)
>
> Are there any changes in there other than the endianness handling?

Hum, yes.
Forget this patch, I post a new one with a complete changelog.
I also noticed that I forgot an error report.

Regards,
Pierre


--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany