Re: [Qemu-devel] [PATCH] vhost-vsock: support parse mergeable feature

[Stefan Hajnoczi]

On Thu, Dec 13, 2018 at 11:27:24AM +0800, jiangyiwen wrote:
> On 2018/12/12 21:19, Michael S. Tsirkin wrote:
> > On Wed, Dec 12, 2018 at 05:54:49PM +0800, jiangyiwen wrote:
> >> Currently vhost-vsock doesn't have any feature bits, so it
> >> don't support parse mergeable rx buffer feature. And the
> >> feature is support in another series of patches named
> >> "VSOCK: support mergeable rx buffer in vhost-vsock".
> >>
> >> So we neet to support parse mergeable feature in vhost-vsock
> >> if above patches are merged.
> >>
> >> Signed-off-by: Yiwen Jiang <address@hidden>
> > 
> > OK but what does it do? this just defines the feature bit ...
> > Also pls copy virtio-dev whenever you change the host/guest
> > interface.
> > 
> > Thanks!
> > 
> 
> Hi Michael,
> 
> In my opinion, for vhost device, device feature bits need to be
> intersected between vhost and qemu, so I add mergeable rx buffer feature
> into vdev->host_features, and then intersected with vhost_dev features.
> 
> Later if someone want to add new feature, it can use virtio_add_feature()
> in vhost_vsock_get_features().

Hi Yiwen,
I think Michael's comment is about documenting the behavior of the new
feature bit.

Each change to a VIRTIO device host<->guest interface needs to be
discussed in the VIRTIO community <address@hidden> and
described in a patch to the VIRTIO specification
(https://github.com/oasis-tcs/virtio-spec/).

Stefan

signature.asc
Description: PGP signature