qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 14/22] qapi: add an error in case a discrimin


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v8 14/22] qapi: add an error in case a discriminator is conditional
Date: Thu, 13 Dec 2018 14:34:22 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Marc-André Lureau <address@hidden> writes:

> Making a discriminator conditional doesn't make much sense.  "qapi:
> add a dictionary form for TYPE" allows it, this patch fixes
> it. Eventually the two could be merged, but for clarity of review it
> is kept separate.
>
> Signed-off-by: Marc-André Lureau <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

I may accept the offer to let me squash it into the previous patch when
I apply.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]