[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_se
From: |
Li Qiang |
Subject: |
[Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock} |
Date: |
Thu, 13 Dec 2018 03:37:51 -0800 |
Also add diagnostics info in 'qemu_set_cloexec' so that we can know
what happen when error occurs.
Signed-off-by: Li Qiang <address@hidden>
---
Change since v1: add diagnostics info
util/oslib-posix.c | 37 ++++++++++++++++++++++++++++++++-----
1 file changed, 32 insertions(+), 5 deletions(-)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index c1bee2a581..14cbef1e35 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -38,6 +38,7 @@
#include <libgen.h>
#include <sys/signal.h>
#include "qemu/cutils.h"
+#include "qemu/error-report.h"
#ifdef CONFIG_LINUX
#include <sys/syscall.h>
@@ -233,14 +234,32 @@ void qemu_set_block(int fd)
{
int f;
f = fcntl(fd, F_GETFL);
- fcntl(fd, F_SETFL, f & ~O_NONBLOCK);
+ if (f < 0) {
+ error_report("Unable to get file status flag on fd %d: %s(errno=%d)",
+ fd, strerror(errno), errno);
+ abort();
+ }
+ if (fcntl(fd, F_SETFL, f & ~O_NONBLOCK) < 0) {
+ error_report("Unable to set blocking flag on fd %d: %s(errno=%d)",
+ fd, strerror(errno), errno);
+ abort();
+ }
}
void qemu_set_nonblock(int fd)
{
int f;
f = fcntl(fd, F_GETFL);
- fcntl(fd, F_SETFL, f | O_NONBLOCK);
+ if (f < 0) {
+ error_report("Unable to get file status flag on fd %d: %s(errno=%d)",
+ fd, strerror(errno), errno);
+ abort();
+ }
+ if (fcntl(fd, F_SETFL, f | O_NONBLOCK) < 0) {
+ error_report("Unable to set nonblocking flag on fd %d: %s(errno=%d)",
+ fd, strerror(errno), errno);
+ abort();
+ }
}
int socket_set_fast_reuse(int fd)
@@ -259,9 +278,17 @@ void qemu_set_cloexec(int fd)
{
int f;
f = fcntl(fd, F_GETFD);
- assert(f != -1);
- f = fcntl(fd, F_SETFD, f | FD_CLOEXEC);
- assert(f != -1);
+ if (f < 0) {
+ error_report("Unable to get fd flags on fd %d: %s(errno=%d)",
+ fd, strerror(errno), errno);
+ abort();
+ }
+ if (fcntl(fd, F_SETFD, f | FD_CLOEXEC) < 0) {
+ error_report("Unable to set fd close-on-exec flag on fd %d:"
+ "%s(errno=%d)",
+ fd, strerror(errno), errno);
+ abort();
+ }
}
/*
--
2.11.0
- [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock},
Li Qiang <=