Re: [Qemu-devel] [PULL 00/54] Misc patches for 2018-12-12

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/54] Misc patches for 2018-12-12

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
16b9e64 vhost-user-test: create a temporary directory per TestServer
dc7e694 vhost-user-test: small changes to init_hugepagefs
b4414a7 vhost-user-test: create a main loop per TestServer
493f5e3 vhost-user-test: reduce usage of global_qtest
80f65ff vhost-user-test: skip if there is no memory at address 0
053b648 vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN
9e1714a vhost-user: support cross-endian vnet headers
6771502 vhost-user-test: signal data_cond when s->rings changes
1f30d35 vhost-user-test: use g_cond_broadcast
c9779b6 vhost-net: revamp configure logic
65060cb vhost-net: compile it on all targets that have virtio-net.
02052a8 vhost: restrict Linux dependency to kernel vhost
2e9125d vhost-net-user: add stubs for when no virtio-net device is present
334c822 vhost-net: move stubs to a separate file
23a88fb hw/watchdog/wdt_i6300esb : remove a unnecessary comment
213a7dc Remove QEMU_ARTIFICIAL macro
2fa6936 includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || 
!defined(__clang__)"
5dc8dfa audio/alsaaudio: Remove compiler check around pragma
9ded950 tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro
5b4272c configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]
f1f6aa3 configure: Remove obsolete check for Clang < 3.2
d7f23f1 configure: Add a test for the minimum compiler version
bb04958 checkpatch: warn about qemu/queue.h head structs that are not typedef-ed
3b17309 qemu/queue.h: simplify reverse access to QTAILQ
e7ca6bd qemu/queue.h: reimplement QTAILQ without pointer-to-pointers
276fe5a qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY}
94d7074 qemu/queue.h: typedef QTAILQ heads
33c8d7f qemu/queue.h: leave head structs anonymous unless necessary
515e852 vfio: make vfio_address_spaces static
f0eff3f qemu/queue.h: do not access tqe_prev directly
279b05a compiler.h: Add an explicit check for the compiler version
17afb2c test: replace gtester with a TAP driver
5ac5663 test: execute g_test_run when tests are skipped
4aa44d3 RFC: qga: drop < Vista compatibility
ce507e2 build-sys: build with Vista API by default
4553cbc build-sys: move windows defines in osdep.h header
75ae603 build-sys: don't include windows.h, osdep.h does it
e759092 scsi: esp: Defer command completion until previous interrupts have been 
handled
eda6b74 esp-pci: Fix status register write erase control
565b3aa block/iscsi: cancel libiscsi task when ABORT TASK TMF completes
363ab7c block/iscsi: fix ioctl cancel use-after-free
e5c91c8 block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()
5213399 block/iscsi: drop unused IscsiAIOCB->buf field
f5729b9 hax: Support for Linux hosts
a050a4d memory: update coalesced_range on transaction_commit
e6bb3cf memory: avoid unnecessary coalesced_io_del operations
dc372b7 memory: extract flat_range_coalesced_io_{del, add}
24905f8 pam: wrap MemoryRegion initialization in a transaction
f03ab76 checkpatch: colorize output to terminal
81e9bae checkpatch: improve handling of multiple patches or files
7bf3d1c checkpatch: check Signed-off-by in --mailback mode
c91e369 checkpatch: fix premature exit when no input or --mailback
15ea796 vhost-user-bridge: fix "unknown type name" compilation error
c837fd5 accel: Improve selection of the default accelerator

=== OUTPUT BEGIN ===
Checking PATCH 1/54: accel: Improve selection of the default accelerator...
Checking PATCH 2/54: vhost-user-bridge: fix "unknown type name" compilation 
error...
Checking PATCH 3/54: checkpatch: fix premature exit when no input or 
--mailback...
Checking PATCH 4/54: checkpatch: check Signed-off-by in --mailback mode...
Checking PATCH 5/54: checkpatch: improve handling of multiple patches or 
files...
ERROR: line over 90 characters
#33: FILE: scripts/checkpatch.pl:345:
+       open($HASH, "-|", "git", "log", "--reverse", "--no-merges", 
"--format=%H %s", $ARGV[0]) ||

ERROR: line over 90 characters
#34: FILE: scripts/checkpatch.pl:346:
+               die "$P: git log --reverse --no-merges --format='%H %s' 
$ARGV[0] failed - $!\n";

WARNING: line over 80 characters
#65: FILE: scripts/checkpatch.pl:373:
+               $vname = substr($hash, 0, 12) . ' (' . $git_commits{$hash} . 
')';

total: 2 errors, 1 warnings, 62 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/54: checkpatch: colorize output to terminal...
Checking PATCH 7/54: pam: wrap MemoryRegion initialization in a transaction...
Checking PATCH 8/54: memory: extract flat_range_coalesced_io_{del, add}...
Checking PATCH 9/54: memory: avoid unnecessary coalesced_io_del operations...
Checking PATCH 10/54: memory: update coalesced_range on transaction_commit...
Checking PATCH 11/54: hax: Support for Linux hosts...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
rename from target/i386/hax-darwin.c

total: 0 errors, 1 warnings, 31 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/54: block/iscsi: drop unused IscsiAIOCB->buf field...
Checking PATCH 13/54: block/iscsi: take iscsilun->mutex in 
iscsi_timed_check_events()...
Checking PATCH 14/54: block/iscsi: fix ioctl cancel use-after-free...
Checking PATCH 15/54: block/iscsi: cancel libiscsi task when ABORT TASK TMF 
completes...
Checking PATCH 16/54: esp-pci: Fix status register write erase control...
Checking PATCH 17/54: scsi: esp: Defer command completion until previous 
interrupts have been handled...
Checking PATCH 18/54: build-sys: don't include windows.h, osdep.h does it...
Checking PATCH 19/54: build-sys: move windows defines in osdep.h header...
WARNING: architecture specific defines should be avoided
#61: FILE: include/qemu/osdep.h:96:
+#ifdef __MINGW32__

total: 0 errors, 1 warnings, 39 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 20/54: build-sys: build with Vista API by default...
Checking PATCH 21/54: RFC: qga: drop < Vista compatibility...
Checking PATCH 22/54: test: execute g_test_run when tests are skipped...
Checking PATCH 23/54: test: replace gtester with a TAP driver...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
deleted file mode 100755

total: 0 errors, 1 warnings, 618 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 24/54: compiler.h: Add an explicit check for the compiler 
version...
Checking PATCH 25/54: qemu/queue.h: do not access tqe_prev directly...
Checking PATCH 26/54: vfio: make vfio_address_spaces static...
Checking PATCH 27/54: qemu/queue.h: leave head structs anonymous unless 
necessary...
Checking PATCH 28/54: qemu/queue.h: typedef QTAILQ heads...
Checking PATCH 29/54: qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY}...
Checking PATCH 30/54: qemu/queue.h: reimplement QTAILQ without 
pointer-to-pointers...
WARNING: line over 80 characters
#176: FILE: include/qemu/queue.h:451:
+#define QTAILQ_IN_USE(elm, field)        ((elm)->field.tqe_circ.tql_prev != 
NULL)

WARNING: line over 80 characters
#185: FILE: include/qemu/queue.h:458:
+        ((typeof((elm)->field.tqe_next)) 
QTAILQ_LINK_PREV((elm)->field.tqe_circ))

WARNING: line over 80 characters
#257: FILE: include/qemu/queue.h:489:
+#define QTAILQ_RAW_INSERT_TAIL(head, elm, entry) do {                          
 \

WARNING: line over 80 characters
#258: FILE: include/qemu/queue.h:490:
+        *QTAILQ_RAW_NEXT(elm, entry) = NULL;                                   
 \

WARNING: line over 80 characters
#259: FILE: include/qemu/queue.h:491:
+        QTAILQ_RAW_TQE_CIRC(elm, entry)->tql_prev = 
QTAILQ_RAW_TQH_CIRC(head)->tql_prev; \

WARNING: line over 80 characters
#260: FILE: include/qemu/queue.h:492:
+        QTAILQ_RAW_TQH_CIRC(head)->tql_prev->tql_next = (elm);                 
 \

WARNING: line over 80 characters
#261: FILE: include/qemu/queue.h:493:
+        QTAILQ_RAW_TQH_CIRC(head)->tql_prev = QTAILQ_RAW_TQE_CIRC(elm, entry); 
 \

WARNING: line over 80 characters
#336: FILE: include/qemu/rcu_queue.h:251:
+    atomic_set(&(elm)->field.tqe_circ.tql_prev->tql_next, 
(elm)->field.tqe_next); \

total: 0 errors, 8 warnings, 315 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 31/54: qemu/queue.h: simplify reverse access to QTAILQ...
Checking PATCH 32/54: checkpatch: warn about qemu/queue.h head structs that are 
not typedef-ed...
WARNING: line over 80 characters
#21: FILE: scripts/checkpatch.pl:2266:
+               if ($line =~ 
/^.\s*(Q(?:S?LIST|SIMPLEQ|TAILQ)_HEAD)\s*\(\s*[^,]/ &&

WARNING: line over 80 characters
#23: FILE: scripts/checkpatch.pl:2268:
+                   ERROR("named $1 should be typedefed separately\n" . 
$herecurr);

total: 0 errors, 2 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 33/54: configure: Add a test for the minimum compiler version...
Checking PATCH 34/54: configure: Remove obsolete check for Clang < 3.2...
Checking PATCH 35/54: configure: Remove old -fno-gcse workaround for GCC 4.6.x 
and 4.7.[012]...
Checking PATCH 36/54: tcg/tcg.h: Remove GCC check for tcg_debug_assert() 
macro...
Checking PATCH 37/54: audio/alsaaudio: Remove compiler check around pragma...
Checking PATCH 38/54: includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || 
!defined(__clang__)"...
WARNING: architecture specific defines should be avoided
#25: FILE: include/qemu/compiler.h:138:
+#if __has_builtin(__builtin_assume_aligned) || !defined(__clang__)

WARNING: architecture specific defines should be avoided
#38: FILE: include/qemu/host-utils.h:210:
+#if __has_builtin(__builtin_clrsb) || !defined(__clang__)

WARNING: architecture specific defines should be avoided
#47: FILE: include/qemu/host-utils.h:226:
+#if __has_builtin(__builtin_clrsbll) || !defined(__clang__)

total: 0 errors, 3 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 39/54: Remove QEMU_ARTIFICIAL macro...
Checking PATCH 40/54: hw/watchdog/wdt_i6300esb : remove a unnecessary comment...
Checking PATCH 41/54: vhost-net: move stubs to a separate file...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 112 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 42/54: vhost-net-user: add stubs for when no virtio-net device 
is present...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#102: 
new file mode 100644

total: 0 errors, 1 warnings, 75 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 43/54: vhost: restrict Linux dependency to kernel vhost...
Checking PATCH 44/54: vhost-net: compile it on all targets that have 
virtio-net....
Checking PATCH 45/54: vhost-net: revamp configure logic...
Checking PATCH 46/54: vhost-user-test: use g_cond_broadcast...
Checking PATCH 47/54: vhost-user-test: signal data_cond when s->rings changes...
Checking PATCH 48/54: vhost-user: support cross-endian vnet headers...
Checking PATCH 49/54: vhost-user-test: support 
VHOST_USER_PROTOCOL_F_CROSS_ENDIAN...
Checking PATCH 50/54: vhost-user-test: skip if there is no memory at address 
0...
Checking PATCH 51/54: vhost-user-test: reduce usage of global_qtest...
WARNING: line over 80 characters
#27: FILE: tests/vhost-user-test.c:190:
+static void init_virtio_dev(QTestState *qts, TestServer *s, uint32_t 
features_mask)

WARNING: line over 80 characters
#60: FILE: tests/vhost-user-test.c:296:
+            uint32_t a = qtest_readb(qts, s->memory.regions[i].guest_phys_addr 
+ j);

total: 0 errors, 2 warnings, 132 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 52/54: vhost-user-test: create a main loop per TestServer...
Checking PATCH 53/54: vhost-user-test: small changes to init_hugepagefs...
Checking PATCH 54/54: vhost-user-test: create a temporary directory per 
TestServer...
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden