[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/5] crypto: support multiple threads accessi
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 5/5] crypto: support multiple threads accessing one QCryptoBlock |
|
Date: |
Mon, 10 Dec 2018 16:24:38 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 10 Dec 2018 04:16:48 PM CET, Daniel P. Berrangé wrote:
>> In other words, the cleanup code won't touch uninitialized elements
>> because it cannot even tell the difference between an index that
>> points to an uninitialized element of the array and an index that
>> points beyond the allocated memory.
>
> .../correctly written/ cleanup code won't touch uninitialized elements...
>
> I prefer to see the code be hardened against mistakes and so would
> always zero-initialize everything unless there's compelling
> performance reason not to in certain specific places.
Ok, sounds reasonable.
Berto
Re: [Qemu-devel] [PATCH v3 0/5] crypto threads, Daniel P . Berrangé, 2018/12/10