[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk'
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom' |
Date: |
Fri, 7 Dec 2018 15:34:00 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Dec 07, 2018 at 03:26:01PM +0000, Anthony PERARD wrote:
> On Fri, Dec 07, 2018 at 02:39:40PM +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > > From: Anthony PERARD [mailto:address@hidden
> > > Sent: 07 December 2018 14:35
> > > To: Paul Durrant <address@hidden>
> > > Cc: address@hidden; address@hidden; xen-
> > > address@hidden; Kevin Wolf <address@hidden>; Max Reitz
> > > <address@hidden>; Stefano Stabellini <address@hidden>
> > > Subject: Re: [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and
> > > 'xen-cdrom'
> > >
> > > On Thu, Dec 06, 2018 at 03:08:29PM +0000, Paul Durrant wrote:
> > > > +static char *disk_to_vbd_name(unsigned int disk)
> > > > +{
> > > > + char *name, *prefix = (disk >= 26) ?
> > > > + disk_to_vbd_name((disk / 26) - 1) : g_strdup("");
> > > > +
> > > > + name = g_strdup_printf("%s%c", prefix, 'a' + disk);
> > >
> > > I don't think that works, if disk is 27, we do ('a' + 27) here. It's
> > > probably missing a `disk % 26`.
> >
> > Damn, yes I was not allowing the >2 letters.
> >
> > >
> > > > + g_free(prefix);
> > > > +
> > > > + return name;
> > > > +}
> > >
> > > [...]
> > >
> > > > +static unsigned int vbd_name_to_disk(const char *name, const char
> > > **endp)
> > > > +{
> > > > + unsigned int disk = 0;
> > > > +
> > > > + while (*name != '\0') {
> > > > + if (!g_ascii_isalpha(*name) || !g_ascii_islower(*name)) {
> > > > + break;
> > > > + }
> > > > +
> > > > + disk *= 26;
> > > > + disk += *name++ - 'a';
> > > > + }
> > > > + *endp = name;
> > > > +
> > > > + return disk;
> > > > +}
> > > > +
> > > > +static void xen_block_set_vdev(Object *obj, Visitor *v, const char
> > > *name,
> > > > + void *opaque, Error **errp)
> > > > +{
> > >
> > > Setting vdev doesn't work. I've tried to add a disk `xvdaa', and it
> > > result in `xvda', or `d0p0' (in the trace). (Same result with `xvdaaa',
> > > and 'xvdba' gives 'xvdaa'/d26p0)
> > >
> >
> > Ok, that's weird. I'll have to figure that out.
>
> It's probably because 'a' is somtime 0 and sometime is 1.
>
> 'a' should be 0
> 'aa' should be 26,
> 'aaa' Seems to be 702.
>
> 'xvda': 0 -> 0 * 1
> 'xvdz': 25 -> 25 * 1
> 'xvdaa': 26 -> 1 * 26 + 0 * 1
> 'xvdaaa': 702 -> 1 * 26^2 + 1 * 26 + 0 * 1
>
> So, it's weird. Have fun fixing the algorithm for that.
Libvirt has code for going in both directions, that's LGPLv2+
licensed if you want it:
https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/util/virutil.c;h=279e6aedc0f5921c850130499fc95c7d4a1e34c9;hb=HEAD#l546
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH v2 04/18] xen: create xenstore areas for XenDevice-s, (continued)
- [Qemu-devel] [PATCH v2 09/18] xen: remove unnecessary code from dataplane/xen-block.c, Paul Durrant, 2018/12/06
- [Qemu-devel] [PATCH v2 07/18] xen: add event channel interface for XenDevice-s, Paul Durrant, 2018/12/06
- [Qemu-devel] [PATCH v2 06/18] xen: add grant table interface for XenDevice-s, Paul Durrant, 2018/12/06
- [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/06
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Anthony PERARD, 2018/12/07
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/07
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Anthony PERARD, 2018/12/07
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom',
Daniel P . Berrangé <=
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/10
[Qemu-devel] [PATCH v2 15/18] xen: add a mechanism to automatically create XenDevice-s..., Paul Durrant, 2018/12/06
[Qemu-devel] [PATCH v2 14/18] xen: add implementations of xen-block connect and disconnect functions..., Paul Durrant, 2018/12/06
[Qemu-devel] [PATCH v2 18/18] xen: remove the legacy 'xen_disk' backend, Paul Durrant, 2018/12/06
[Qemu-devel] [PATCH v2 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c, Paul Durrant, 2018/12/06