|
From: | Li Zhijian |
Subject: | Re: [Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context |
Date: | Thu, 6 Dec 2018 13:56:15 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 12/06/2018 04:37 AM, Marc-André Lureau wrote:
COLO uses a worker context (iothread) to drive the chardev. All backends are not able to switch the context, let's report an error in this case. Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Li Zhijian <address@hidden>
--- net/colo-compare.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index a39191d522..9156ab3349 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -957,6 +957,12 @@ static int find_and_check_chardev(Chardev **chr, return 1; }+ if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_GCONTEXT)) {+ error_setg(errp, "chardev \"%s\" cannot switch context", + chr_name); + return 1; + } + return 0; }
[Prev in Thread] | Current Thread | [Next in Thread] |