qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC for 3.1? or 4 v3 1/1] qemu-iotests: Don't run the


From: Farhan Ali
Subject: Re: [Qemu-devel] [RFC for 3.1? or 4 v3 1/1] qemu-iotests: Don't run the test when user is root
Date: Fri, 30 Nov 2018 16:51:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0



On 11/30/2018 03:52 PM, Eric Blake wrote:
On 11/30/18 2:37 PM, Farhan Ali wrote:
Test 232 creates image files with read-only permission and
expects an error message when trying to access the image
files with read-only and auto-read-only turned off.

Don't run as root user, since root can open files with read/write
access for read-only files.

Signed-off-by: Farhan Ali <address@hidden>
---
  tests/qemu-iotests/232 | 5 +++++
  1 file changed, 5 insertions(+)

Did you mean to keep RFC in the subject line?  Will patchew even spot it without PATCH in the subject line?

Reviewed-by: Eric Blake <address@hidden>

Thanks for reviewing the patch. I am not sure if patchew will pick it up; I have no problem in spinning another patch but I will wait till Monday to see if anyone else has any feedback.

Thanks
Farhan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]