Re: [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers

[Dr. David Alan Gilbert]

* Marc-André Lureau (address@hidden) wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> ---
>  include/migration/register.h | 2 +-
>  migration/savevm.c           | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/migration/register.h b/include/migration/register.h
> index d287f4c317..3d0b9833c6 100644
> --- a/include/migration/register.h
> +++ b/include/migration/register.h
> @@ -72,7 +72,7 @@ int register_savevm_live(DeviceState *dev,
>                           const char *idstr,
>                           int instance_id,
>                           int version_id,
> -                         SaveVMHandlers *ops,
> +                         const SaveVMHandlers *ops,
>                           void *opaque);
>  
>  void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque);
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 236b242642..00a054721a 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -303,7 +303,7 @@ typedef struct SaveStateEntry {
>      int section_id;
>      /* section id read from the stream */
>      int load_section_id;
> -    SaveVMHandlers *ops;
> +    const SaveVMHandlers *ops;
>      const VMStateDescription *vmsd;
>      void *opaque;
>      CompatEntry *compat;
> @@ -614,7 +614,7 @@ int register_savevm_live(DeviceState *dev,
>                           const char *idstr,
>                           int instance_id,
>                           int version_id,
> -                         SaveVMHandlers *ops,
> +                         const SaveVMHandlers *ops,
>                           void *opaque)
>  {
>      SaveStateEntry *se;
> -- 
> 2.19.1.708.g4ede3d42df
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK