[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1? v2] hostmem: Validate host-nodes before
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH for-3.1? v2] hostmem: Validate host-nodes before setting bitmap |
|
Date: |
Fri, 30 Nov 2018 18:55:39 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 11/30/18 6:28 AM, Eduardo Habkost wrote:
>> host_memory_backend_set_host_nodes() was not validating
>> host-nodes before writing to backend->host_nodes, making QEMU
>> write beyond the end of the bitmap.
>>
>> Fix the crash and add a simple regression test for the fix.
>>
>> While at it, fix memory leak of the list returned by
>> visit_type_uint16List().
>>
>> Reported-by: Markus Armbruster <address@hidden>
>> Signed-off-by: Eduardo Habkost <address@hidden>
>> ---
>
> Looks like we may have 3.1-rc4 due to some CVE fixes; is this worth
> including in 3.1 as well?
You could conceivably crash a running VM with object-add. On the other
hand, the bug has been around for a while, and was only found by code
inspection.