[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qapi: split host-qmp into quit and system-r
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qapi: split host-qmp into quit and system-reset |
Date: |
Fri, 30 Nov 2018 07:55:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 11/30/18 7:20 AM, Dominik Csapak wrote:
On 11/30/18 10:41 AM, Markus Armbruster wrote:
Cc: Pavel to assess possible impact on replay.
Cc: Eric to give him a chance to correct misunderstandings of
ShutdownCause.
I still need to look more closely at the series, but in answer to your
question,
yeah switching 2 and 3 makes sense, i guess i did it this way so that
i only have to touch the iotests one time
should i fix the iotests in both 2 and 3 when i switch them ?
(with 2 the reason gets added there, and 3 changes the reason)
or should i send an extra patch (4/4) that fixes only the iotests?
or only change them in 3/3 ?
Ideally, iotests should pass after each commit (reduces chance of
confusion down the road when a 'git bisect' is trying to pinpoint a
cause of some other iotest failure). iotests are a bit fuzzier than
'make check' in terms of how long things are allowed to be checked in
with known failures (in part because iotests has so many different ways
to be run, and not all configurations are run all the times, so many
corner-case configurations end up broken over long stretches of commits
without realizing it), so that at least gives you some flexibility. But
if you KNOW the test is broken, and reordering the patches or tweaking
the tests to pass is easy, then you might as well do it.
Churn in the tests as output changes is not too bad - especially if it
shows that the patch is accomplishing its stated purpose of making the
expected output nicer. So having the test fixed in 2 to show the reason
and again in 3 to show a change in the reason makes sense for a patch
series.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org