[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1?] hw/arm/aspeed: Fix build issue with cl
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PATCH for-3.1?] hw/arm/aspeed: Fix build issue with clang 3.4 |
Date: |
Wed, 28 Nov 2018 14:09:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
Hello Thomas,
On 11/28/18 10:35 AM, Thomas Huth wrote:
> When using clang 3.4.2, compilation of QEMU fails like this:
>
> CC aarch64-softmmu/hw/arm/aspeed.o
> hw/arm/aspeed.c:36:3: error: redefinition of typedef 'AspeedBoardState' is a
> C11
> feature [-Werror,-Wtypedef-redefinition]
> } AspeedBoardState;
> ^
> include/hw/arm/aspeed.h:14:33: note: previous definition is here
> typedef struct AspeedBoardState AspeedBoardState;
> ^
> 1 error generated.
> make[1]: *** [hw/arm/aspeed.o] Error 1
> make: *** [subdir-aarch64-softmmu] Error 2
>
> Remove the duplicated typedef to fix this issue.
>
> Signed-off-by: Thomas Huth <address@hidden>
yes. May be for 3.1.
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> hw/arm/aspeed.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 6b33ecd..5158985 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -29,11 +29,11 @@ static struct arm_boot_info aspeed_board_binfo = {
> .nb_cpus = 1,
> };
>
> -typedef struct AspeedBoardState {
> +struct AspeedBoardState {
> AspeedSoCState soc;
> MemoryRegion ram;
> MemoryRegion max_ram;
> -} AspeedBoardState;
> +};
>
> /* Palmetto hardware value: 0x120CE416 */
> #define PALMETTO_BMC_HW_STRAP1 ( \
>