Re: [Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

[Peter Maydell]

On Wed, 28 Nov 2018 at 10:40, Samuel Ortiz <address@hidden> wrote:
> Given that this piece of code effectively builds a dependency to TCG
> from the KVM code, I see a few solutions but I need your input here. We
> could:
>
> - Decide we don't want to support --disable-tcg for ARM. We'd then carry
>   this patch serie from the NEMU code repo. Worst case scenario, at
>   least for us.
> - Manage to implement exception injection from userspace without TCG.
>   Would it even be possible?
> - Offload exception injections back to the kernel in those cases. I feel
>   this would be the cleanest solution but may need kernel changes.

The kernel folk were firmly against 3, IIRC, but you can go
and have the discussion if you like.

I don't really see what the problem is. This is just a bit
of code that's used by both TCG and KVM. Therefore it goes
in the binary whether TCG is enabled or not. Other functions
and bits of code are TCG only and therefore don't go in a
KVM-only binary. --disable-tcg just means "remove the code
we don't need"; there's nothing special about these functions
that says "they're really TCG and should be removed here".

thanks
-- PMM