[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] trace: simple style changes
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH] trace: simple style changes |
Date: |
Tue, 27 Nov 2018 14:23:28 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 11/27/18 2:08 PM, Larry Dewey wrote:
> This changes two lines in simple.c that end with a comma, and replaces them
> with a semi-colon.
>
> Signed-off-by: Larry Dewey <address@hidden>
> ---
> trace/simple.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/trace/simple.c b/trace/simple.c
> index 701dec639c..ac904eca91 100644
> --- a/trace/simple.c
> +++ b/trace/simple.c
> @@ -169,9 +169,9 @@ static gpointer writeout_thread(gpointer opaque)
> wait_for_trace_records_available();
>
> if (g_atomic_int_get(&dropped_events)) {
> - dropped.rec.event = DROPPED_EVENT_ID,
> + dropped.rec.event = DROPPED_EVENT_ID;
> dropped.rec.timestamp_ns = get_clock();
> - dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t),
> + dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t);
> dropped.rec.pid = trace_pid;
> do {
> dropped_count = g_atomic_int_get(&dropped_events);
>
I can't see any reason for why sequence points were used, other than in
62bab73213ba885426a781eb2741670b9f3cae36 getting mixed up between
if (cond) { ...; ... } and an earlier var = (type) { ..., ... }.
Reviewed-by: John Snow <address@hidden>