[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] glib-compat: work around g_test_message bug wit
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] glib-compat: work around g_test_message bug with subprocess tests |
|
Date: |
Tue, 27 Nov 2018 19:55:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 27/11/18 19:49, Marc-André Lureau wrote:
> good catch! makes me wonder if g_test_message() is supposed to be
> usable in a subprocess.. Let see the review comments on upstream bug.
> At least, documentation should be updated.
>
> Reviewed-by: Marc-André Lureau <address@hidden>
Considering that GLib goes to great lengths to pass the test log fd as
--GTestFD, it definitely should. So the alternative is not that that
documentation should be updated, the test log file descriptor should not
be passed.
Paolo