[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash |
Date: |
Tue, 27 Nov 2018 09:18:04 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Nov 27, 2018 at 09:41:43AM +0100, Markus Armbruster wrote:
> qemu_vfio_open_common() initializes s->lock only after passing s to
> qemu_vfio_dma_map() via qemu_vfio_init_ramblock().
> qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes.
>
> Fix by initializing s->lock first.
>
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1645840
> Fixes: 418026ca43bc2626db092d7558258f9594366f28
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> Compile-tested only, as I lack suitable hardware. Cong Li (cc'ed) is
> going to test it for real. It looks obvious enough to me to put it
> into -rc3 without waiting for the test results. We can also wait and
> put it into -rc4.
>
> util/vfio-helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature