[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/6] audio/hda: fix guest triggerable assert
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/6] audio/hda: fix guest triggerable assert |
Date: |
Tue, 27 Nov 2018 07:49:30 +0100 |
Guest writes to a readonly register trigger the assert in
intel_hda_reg_write(). Add a check and just ignore them.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1628433
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
---
hw/audio/intel-hda.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index 23a2cf6484..33e333cc26 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -23,6 +23,7 @@
#include "hw/pci/msi.h"
#include "qemu/timer.h"
#include "qemu/bitops.h"
+#include "qemu/log.h"
#include "hw/audio/soundhw.h"
#include "intel-hda.h"
#include "intel-hda-defs.h"
@@ -929,6 +930,11 @@ static void intel_hda_reg_write(IntelHDAState *d, const
IntelHDAReg *reg, uint32
if (!reg) {
return;
}
+ if (!reg->wmask) {
+ qemu_log_mask(LOG_GUEST_ERROR, "intel-hda: write to r/o reg %s\n",
+ reg->name);
+ return;
+ }
if (d->debug) {
time_t now = time(NULL);
--
2.9.3
- [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches, Gerd Hoffmann, 2018/11/27
- [Qemu-devel] [PULL 2/6] ps2kbd: default to scan enabled after reset, Gerd Hoffmann, 2018/11/27
- [Qemu-devel] [PULL 4/6] audio/hda: fix guest triggerable assert,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 5/6] usb-host: set ifs.detached as true if kernel driver is not active, Gerd Hoffmann, 2018/11/27
- [Qemu-devel] [PULL 3/6] cirrus_vga/migration: update the bank offset before use, Gerd Hoffmann, 2018/11/27
- [Qemu-devel] [PULL 6/6] qapi: add query-display-options command, Gerd Hoffmann, 2018/11/27
- [Qemu-devel] [PULL 1/6] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size, Gerd Hoffmann, 2018/11/27
- Re: [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches, Peter Maydell, 2018/11/27
- Re: [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches, no-reply, 2018/11/28