[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command |
Date: |
Mon, 26 Nov 2018 16:13:25 +0100 |
User-agent: |
NeoMutt/20180716 |
On Mon, Nov 26, 2018 at 03:01:42PM +0100, Markus Armbruster wrote:
> Gerd Hoffmann <address@hidden> writes:
>
> > Add query-display-options command, which allows querying the qemu
> > display configuration, and -- as an intentional side effect -- makes
> > DisplayOptions discoverable via query-qmp-schema so libvirt can go
> > figure which display options are supported.
> >
> > Use case: commit d4dc4ab1 added rendernode parameter for egl-headless.
>
> I understand why exposing DisplayOptions in query-qmp-schema is useful.
> But can you think of a use for the new command?
>
> If not, then this is a workaround for lack of CLI introspection.
> That's okay, ball's in my court on that. But I'd like to have the
> "workaroundness" spelled out in the commit message then.
Sure. I assumed the "intentional side effect" message is clear enough
though.
The command itself isn't that helpful, you should know how you have
started qemu ...
cheers,
Gerd