Re: [Qemu-devel] [PATCH for-4.0 v2 04/37] tcg: Add TCG_TARGET_NEED_LDST_OOL_LABELS

[Emilio G. Cota]

On Fri, Nov 23, 2018 at 15:45:25 +0100, Richard Henderson wrote:
> This variant of tcg-ldst.inc.c allows the entire thunk to be
> moved out-of-line, with caching across TBs within a region.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
(snip)
> +++ b/tcg/tcg-ldst-ool.inc.c
(snip)
> +typedef struct TCGLabelQemuLdstOol {
> +    QSIMPLEQ_ENTRY(TCGLabelQemuLdstOol) next;
> +    tcg_insn_unit *label;   /* label pointer to be updated */
> +    int reloc;              /* relocation type from label_ptr */
> +    intptr_t addend;        /* relocation addend from label_ptr */
> +    uint32_t key;           /* oi : is_64 : is_ld */
> +} TCGLabelQemuLdstOol;

Just a tiny nit, here we can move reloc down to plug a hole.

                Emilio