Re: [Qemu-devel] [PATCH v5 17/24] hw/pvrdma: Fill error code in command's response

[Yuval Shaia]

> >       err = cmd_handlers[dsr_info->req->hdr.cmd].exec(dev, dsr_info->req,
> > -                            dsr_info->rsp);
> > +                                                    dsr_info->rsp);
> >   out:
> >       set_reg_val(dev, PVRDMA_REG_ERR, err);
> >       post_interrupt(dev, INTR_VEC_CMD_RING);
> 
> 
> As I responded in V4 thread :) one might forget to set hdr.error to 0
> resulting in errors hard to debug.
> 
> Please consider clearing the field on init.

Will fix.

> 
> Reviewed-by: Marcel Apfelbaum <address@hidden>

Please review v6.

> 
> Thanks,
> Marcel