[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/21] milkymist-pfpu: Convert sysbus init fu
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/21] milkymist-pfpu: Convert sysbus init function to realize function |
Date: |
Fri, 23 Nov 2018 16:40:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> milkymist_pfpu_class_init().
>
> Cc: address@hidden
>
> Signed-off-by: Mao Zhongyi <address@hidden>
> Signed-off-by: Zhang Shengju <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/misc/milkymist-pfpu.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/hw/misc/milkymist-pfpu.c b/hw/misc/milkymist-pfpu.c
> index 86f5e383b0..4a03c7ee63 100644
> --- a/hw/misc/milkymist-pfpu.c
> +++ b/hw/misc/milkymist-pfpu.c
> @@ -497,17 +497,16 @@ static void milkymist_pfpu_reset(DeviceState *d)
> }
> }
>
> -static int milkymist_pfpu_init(SysBusDevice *dev)
> +static void milkymist_pfpu_realize(DeviceState *dev, Error **errp)
> {
> MilkymistPFPUState *s = MILKYMIST_PFPU(dev);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
>
> - sysbus_init_irq(dev, &s->irq);
> + sysbus_init_irq(sbd, &s->irq);
>
> memory_region_init_io(&s->regs_region, OBJECT(dev), &pfpu_mmio_ops, s,
> "milkymist-pfpu", MICROCODE_END * 4);
> - sysbus_init_mmio(dev, &s->regs_region);
> -
> - return 0;
> + sysbus_init_mmio(sbd, &s->regs_region);
> }
>
> static const VMStateDescription vmstate_milkymist_pfpu = {
> @@ -527,9 +526,8 @@ static const VMStateDescription vmstate_milkymist_pfpu = {
> static void milkymist_pfpu_class_init(ObjectClass *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
>
> - k->init = milkymist_pfpu_init;
> + dc->realize = milkymist_pfpu_realize;
> dc->reset = milkymist_pfpu_reset;
> dc->vmsd = &vmstate_milkymist_pfpu;
> }
>
- Re: [Qemu-devel] [PATCH v2 07/21] gpio/puv3_gpio: Convert sysbus init function to realize function, (continued)
- [Qemu-devel] [PATCH v2 06/21] dma/puv3_dma: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 08/21] milkymist-softusb: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 03/21] char/grlib_apbuart: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 09/21] input/pl050: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 01/21] musicpal: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 12/21] milkymist-pfpu: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- Re: [Qemu-devel] [PATCH v2 12/21] milkymist-pfpu: Convert sysbus init function to realize function,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 14/21] nvram/ds1225y: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 16/21] timer/etraxfs_timer: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 05/21] display/g364fb: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 19/21] usb/tusb6010: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 10/21] intc/puv3_intc: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23
- [Qemu-devel] [PATCH v2 17/21] timer/grlib_gptimer: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/23