[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency chec
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks |
Date: |
Wed, 21 Nov 2018 11:38:33 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* Zhang Chen (address@hidden) wrote:
> From: Zhang Chen <address@hidden>
>
> Current COLO mode(independent disk mode) need replication module work
> together. Suggested by Dr. David Alan Gilbert <address@hidden>.
>
> Signed-off-by: Zhang Chen <address@hidden>
Queued
> ---
> migration/migration.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index b261c1e4ce..49ffb9997a 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -918,6 +918,15 @@ static bool migrate_caps_check(bool *cap_list,
> }
> #endif
>
> +#ifndef CONFIG_REPLICATION
> + if (cap_list[MIGRATION_CAPABILITY_X_COLO]) {
> + error_setg(errp, "QEMU compiled without replication module"
> + " can't enable COLO");
> + error_append_hint(errp, "Please enable replication before COLO.\n");
> + return false;
> + }
> +#endif
> +
> if (cap_list[MIGRATION_CAPABILITY_POSTCOPY_RAM]) {
> if (cap_list[MIGRATION_CAPABILITY_COMPRESS]) {
> /* The decompression threads asynchronously write into RAM
> --
> 2.17.GIT
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK