Re: [Qemu-devel] [PATCH for-3.1?] qtest: log QEMU command line

[Thomas Huth]

On 2018-11-15 13:29, Paolo Bonzini wrote:
> Record the command line that was used to start QEMU.  This can be
> useful for debugging.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  tests/libqtest.c | 26 +++++++++++++++-----------
>  1 file changed, 15 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 44ce118cfc..f6e061da44 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -215,24 +215,28 @@ QTestState *qtest_init_without_qmp_handshake(bool 
> use_oob,
>  
>      qtest_add_abrt_handler(kill_qemu_hook_func, s);
>  
> +    command = g_strdup_printf("exec %s "
> +                              "-qtest unix:%s,nowait "
> +                              "-qtest-log %s "
> +                              "-chardev socket,path=%s,nowait,id=char0 "
> +                              "-mon chardev=char0,mode=control%s "
> +                              "-machine accel=qtest "
> +                              "-display none "
> +                              "%s", qemu_binary, socket_path,
> +                              getenv("QTEST_LOG") ? "/dev/fd/2" : 
> "/dev/null",
> +                              qmp_socket_path, use_oob ? ",x-oob=on" : "",
> +                              extra_args ?: "");
> +
> +    g_test_message("starting QEMU: %s\n", command);

I think we don't need the trailing \n here, do we? Looking at the output
when I run a test with --verbose, it seems like glib is taking care of
this already... (if you agree, I can fix it up when picking the patch up)

 Thomas