[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.2 01/41] slirp: move socket pair creation
|
From: |
Samuel Thibault |
|
Subject: |
Re: [Qemu-devel] [PATCH for-3.2 01/41] slirp: move socket pair creation in helper function |
|
Date: |
Mon, 19 Nov 2018 23:46:30 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hello,
Marc-André Lureau, le mer. 14 nov. 2018 16:36:03 +0400, a ecrit:
> Originally, the patch was fixing a bunch of issues, but Peter beat me
> to it with earlier commit "slirp: fork_exec(): create and connect
> child socket before fork()".
>
> Factor out socket pair creation, to simplify the fork_exec() code.
> Use the name socketpair_with_oob() since the code is actually similar
> to what socketpair() would do, except that it uses TCP sockets, for
> SLIRP to be able to call send with MSG_OOB (since SO_OOBINLINE is set,
> this could probably be faked instead on regular unix sockets though).
>
> Signed-off-by: Marc-André Lureau <address@hidden>
Applied to my tree, thanks!
Samuel