[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/stm32f205: Fix the UART and Timer region
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/stm32f205: Fix the UART and Timer region size |
Date: |
Mon, 19 Nov 2018 11:08:04 +0000 |
On 19 November 2018 at 10:43, Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Seth,
>
> On Mon, Nov 19, 2018 at 4:17 AM Seth K <address@hidden> wrote:
>>
>> From: Seth Kintigh <address@hidden>
>>
>> I corrected these 2 memory regions based on specifications from the chip
>> manufacturer. The existing ranges seem to overlap and and cause odd
>> behavior and/or crashes when trying to set up multiple UARTs,
>>
>> Signed-off-by: Seth Kintigh <address@hidden>
>> ---
>> Phil, I hope this is the right format.
>
> Better but still incorrect.
What Phil says below is true, but since this is a simple
patch I have applied it by hand to my target-arm.next branch,
so it will go into the next release of QEMU. Thanks for your
contribution! (I rewrote the commit message a bit to make
it fit in with the usual style we use for our commit messages;
I hope that's OK.)
> I tried to apply your patch but get an error:
>
> $ git am seth_stm32f2xx_regsize.mbox
I suspect this is because the email is in dual text/HTML format.
thanks
-- PMM