qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/3] qemu-iotests: remove unused variable her


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 2/3] qemu-iotests: remove unused variable here
Date: Fri, 16 Nov 2018 10:49:59 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

On 10/24/18 6:26 PM, Philippe Mathieu-Daudé wrote:
Hi Mao,

On 24/10/18 11:40, Mao Zhongyi wrote:
run
git grep '\$here' tests/qemu-iotests

Correct. You want both the \ and the $ to be handed to the grep regex.


This command doesn't look correct, I believe you have to use either

- git grep '$here'

Nope - here, $ is unquoted to grep, so it matches end of line, and you can't match 'here' after end of line.

or
- git grep \$here

Ditto.



has 0 hits, which means we are setting a variable that
no use, so execute the following cmd to remove all of
the 'here=...' lines as dead code.

This seems to have been removed in e8f8624d3b920de.

Worthwhile to mention in the commit message.



sed -i '/here=/d' $(git grep -l 'here=' tests/qemu-iotests)

Cc: address@hidden
Cc: address@hidden
Cc: address@hidden

Suggested-by: Eric Blake <address@hidden>

Please Cc Eric if he suggested, so he can review.

I was cc'd - but mailman is stupid and rewrites the cc line sent to the list because of my settings (I really wish it wouldn't).

Reviewed-by: Eric Blake <address@hidden>

I might just queue this through my NBD tree, since I noticed the issue again in test 233 just proposed by Dan.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]