[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 1/7] cpus: correct coding style in qmp_memsave/qm
From: |
Simon Ruderich |
Subject: |
[Qemu-devel] [PATCH v8 1/7] cpus: correct coding style in qmp_memsave/qmp_pmemsave |
Date: |
Thu, 15 Nov 2018 15:07:12 +0100 |
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Simon Ruderich <address@hidden>
---
cpus.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index a2b33ccb29..e67efbb58b 100644
--- a/cpus.c
+++ b/cpus.c
@@ -2394,8 +2394,9 @@ void qmp_memsave(int64_t addr, int64_t size, const char
*filename,
while (size != 0) {
l = sizeof(buf);
- if (l > size)
+ if (l > size) {
l = size;
+ }
if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) != 0) {
error_setg(errp, "Invalid addr 0x%016" PRIx64 "/size %" PRId64
" specified", orig_addr, orig_size);
@@ -2428,8 +2429,9 @@ void qmp_pmemsave(int64_t addr, int64_t size, const char
*filename,
while (size != 0) {
l = sizeof(buf);
- if (l > size)
+ if (l > size) {
l = size;
+ }
cpu_physical_memory_read(addr, buf, l);
if (fwrite(buf, 1, l, f) != l) {
error_setg(errp, QERR_IO_ERROR);
--
2.19.1
- [Qemu-devel] [PATCH v8 0/7] qmp: add pmemload command, Simon Ruderich, 2018/11/15
- [Qemu-devel] [PATCH v8 4/7] hmp: use l for size argument in memsave/pmemsave, Simon Ruderich, 2018/11/15
- [Qemu-devel] [PATCH v8 1/7] cpus: correct coding style in qmp_memsave/qmp_pmemsave,
Simon Ruderich <=
- [Qemu-devel] [PATCH v8 3/7] cpus: use size_t in qmp_memsave/qmp_pmemsave, Simon Ruderich, 2018/11/15
- [Qemu-devel] [PATCH v8 5/7] hmp: use F for filename arguments in memsave/pmemsave, Simon Ruderich, 2018/11/15
- [Qemu-devel] [PATCH v8 2/7] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open, Simon Ruderich, 2018/11/15
- [Qemu-devel] [PATCH v8 6/7] qmp: add pmemload command, Simon Ruderich, 2018/11/15
- [Qemu-devel] [PATCH v8 7/7] hmp: add pmemload command, Simon Ruderich, 2018/11/15