Re: [Qemu-devel] [PATCH] Corrected memory regions

[Peter Maydell]

On 4 November 2018 at 07:42, Seth K <address@hidden> wrote:
> I corrected these 2 memory regions based on specifications from the chip
> manufacturer. The existing ranges seem to overlap and and cause odd
> behavior and/or crashes when trying to set up multiple UARTs,
> I also played with changing MAX_SERIAL_PORTS to 8 to match the hardware,
> but I did not include that in this patch as I never fully tested its
> effects.

Hi; thanks for the patch. As Philippe says, it looks good,
but the one thing we definitely need is a Signed-off-by:
line from you.

A minor note -- there is no "MAX_SERIAL_PORTS" definition
in QEMU any more: we removed that artificial limitation
earlier this year. Maybe you're basing your patch on an
older version of QEMU? It's best to use git master for
development. Our SoC model defines 6 uarts (STM_NUM_USARTS)
in hw/arm/stm32f205_soc.c, which should all now be connectable
on the command line, though I haven't tested that or checked
whether the hardware has 6 or some other number...

thanks
-- PMM