qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] simple firmware.json test tool


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] simple firmware.json test tool
Date: Thu, 15 Nov 2018 11:21:05 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

On 15/11/18 8:56, Gerd Hoffmann wrote:
   Hi,

Perhaps print a few shell commands first? Such as:

    (
      VARSTORE=$(mktemp)
      trap 'rm -f -- "$VARSTORE"' EXIT
      cat -- '[VARSTORE_TEMPLATE]' >> "$VARSTORE"
      qemu ...
    )

It really does take separate actions, just like when you create a new
disk image with "qemu-img".

Any plan to respin this patch?

-ENOTIME[1].  Also no really good idea how to handle varstore.

I'd like to have something simple, so it is easy run qemu with the
correct arguments.  Just ...

   qemu-system-$arch $(qemu-firmware /path/to/firmware.json)

... would be cool, but varstore handling isn't going to fly that way.

Maybe we really have to print some shell commands and set some specific
variables, so one can do something like this:

   eval $(qemu-firmware /path/to/firmware.json)
   qemu-system-${QEMU_FIRMWARE_ARCH} ${QEMU_FIRMWARE_ARGS}

cheers,
   Gerd

[1] feel free to pick it up.

OK, thanks!

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]