[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.2 35/41] slirp: NULL is defined by glib (a
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH for-3.2 35/41] slirp: NULL is defined by glib (at least) |
Date: |
Wed, 14 Nov 2018 14:11:34 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
NULL is defined in stddef.h for at least 15 years AFAICT, so
even glib shouldn't bother to define it :-) So I'd suggest
changing $subject to just defer to stddef.h
On Wed, Nov 14, 2018 at 04:36:37PM +0400, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> slirp/slirp.h | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
>
> diff --git a/slirp/slirp.h b/slirp/slirp.h
> index 4356b2f427..2a61a85995 100644
> --- a/slirp/slirp.h
> +++ b/slirp/slirp.h
> @@ -199,10 +199,6 @@ struct Slirp {
> void *opaque;
> };
>
> -#ifndef NULL
> -#define NULL (void *)0
> -#endif
> -
> void if_start(Slirp *);
>
> int get_dns_addr(struct in_addr *pdns_addr);
> --
> 2.19.1.708.g4ede3d42df
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH for-3.2 29/41] slirp: improve a bit the debug macros, (continued)
- [Qemu-devel] [PATCH for-3.2 29/41] slirp: improve a bit the debug macros, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 33/41] slirp: replace qemu_notify_event() with a callback, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 34/41] slirp: remove #if notdef dead code, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 35/41] slirp: NULL is defined by glib (at least), Marc-André Lureau, 2018/11/14
- Re: [Qemu-devel] [PATCH for-3.2 35/41] slirp: NULL is defined by glib (at least),
Daniel P . Berrangé <=
- [Qemu-devel] [PATCH for-3.2 36/41] slirp: remove dead TCP_ACK_HACK code, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 37/41] slirp: replace ARRAY_SIZE with G_N_ELEMENTS, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals, Marc-André Lureau, 2018/11/14