Re: [Qemu-devel] [PATCH 00/13] Support disabling TCG on ARM

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH 00/13] Support disabling TCG on ARM

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3af868c target: arm: Do not build TCG objects when TCG is off
cb922de target: arm: Makefile cleanup
44ffa5e target: arm: Define TCG dependent functions when TCG is enabled
b68743a target: arm: Move watchpoints APIs to helper.c
9e2028d target: arm: Move CPU state dumping routines to helper.c
3a52e33 target: arm: Move all VFP helpers into their own file
c39a434 target: arm: Remove the LDST headers
90d9715 target: arm: Make ARM TLB filling routine static
f726b41 target: arm: Move the DC ZVA helper into op_helper
ffc449b target: arm: Move all interrupt and exception handlers into their own 
file
b76f167 target: arm: Move all v7m helpers into their own file
8f010ec target: arm: Remove unused headers
dfb3f64 target: arm: Add copyright boilerplate

=== OUTPUT BEGIN ===
Checking PATCH 1/13: target: arm: Add copyright boilerplate...
Checking PATCH 2/13: target: arm: Remove unused headers...
Checking PATCH 3/13: target: arm: Move all v7m helpers into their own file...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#2165: 
new file mode 100644

total: 0 errors, 1 warnings, 4002 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/13: target: arm: Move all interrupt and exception handlers 
into their own file...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 1095 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/13: target: arm: Move the DC ZVA helper into op_helper...
Checking PATCH 6/13: target: arm: Make ARM TLB filling routine static...
Checking PATCH 7/13: target: arm: Remove the LDST headers...
Checking PATCH 8/13: target: arm: Move all VFP helpers into their own file...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#916: 
new file mode 100644

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#935: FILE: target/arm/vfp_helper.c:15:
+#define VFP_BINOP(name)                                                 \
+float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp)          \
+{                                                                       \
+    float_status *fpst = fpstp;                                         \
+    return float32_ ## name(a, b, fpst);                                \
+}                                                                       \
+float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp)          \
+{                                                                       \
+    float_status *fpst = fpstp;                                         \
+    return float64_ ## name(a, b, fpst);                                \
+}

ERROR: space prohibited before that close parenthesis ')'
#1048: FILE: target/arm/vfp_helper.c:128:
+    CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, )                      \

ERROR: space prohibited before that close parenthesis ')'
#1051: FILE: target/arm/vfp_helper.c:131:
+FLOAT_CONVS(si, h, uint32_t, 16, )

ERROR: space prohibited before that close parenthesis ')'
#1052: FILE: target/arm/vfp_helper.c:132:
+FLOAT_CONVS(si, s, float32, 32, )

ERROR: space prohibited before that close parenthesis ')'
#1053: FILE: target/arm/vfp_helper.c:133:
+FLOAT_CONVS(si, d, float64, 64, )

ERROR: space prohibited before that close parenthesis ')'
#1095: FILE: target/arm/vfp_helper.c:175:
+                         get_float_rounding_mode(fpst), )

ERROR: space prohibited before that close parenthesis ')'
#1100: FILE: target/arm/vfp_helper.c:180:
+                         get_float_rounding_mode(fpst), )

total: 7 errors, 1 warnings, 1778 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/13: target: arm: Move CPU state dumping routines to helper.c...
Checking PATCH 10/13: target: arm: Move watchpoints APIs to helper.c...
Checking PATCH 11/13: target: arm: Define TCG dependent functions when TCG is 
enabled...
Checking PATCH 12/13: target: arm: Makefile cleanup...
Checking PATCH 13/13: target: arm: Do not build TCG objects when TCG is off...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden